Showing posts with label GitHub. Show all posts
Showing posts with label GitHub. Show all posts

Monday, August 10, 2015

2015 goal reached: contribute to open-source project!

I reached one of my 2015 goals: contribute to an open source project. I have to say, it was tiny contribution, but hey, Rome wasn't built in a day either.


Here's my pull request: https://github.com/tamasvajk/SkyScanner/pull/4 in case you're interested.

I'm using the SkyScanner nuget package at work and I needed some modifications to it. Obviously I didn't want to go down the route of re-writing the library myself so I forked it on GitHub and got in touch with Tamas Vajk ( owner of the library ) and created a new issue with some of his input: https://github.com/tamasvajk/SkyScanner/issues/3. After sparring about some ideas on how to implement it, I finally squashed my commits and sent a pull-request for the feature over to him and he accepted yesterday. So there you have it: my first accepted pull-request and contribution to open-source.




It was an interesting experience - I'll think I'll recap on it in a later post. I do recommend it for everyone though !

Wednesday, August 5, 2015

Git rebase --i = nice :)

I'm trying to contribute to the NuGet SkyScanner package - which is hosted on GitHub. I've forked the library and made my changes - and now I wanted to create a pull-request.

Great - works fine, however the pull request had all the small commits in that I made for myself, but it will not be very nice to have all of them in the original repository. Therefore, I wanted to get them all into one single commit and create a pull request for that.

Turns out to be a piece of cake:


Turns out, you need to squash your commits and force push it to the GitHub repository. It's going to require some command line wizardry ( even on Windows ), so prepare for some cmd and even some Vim, but it is definately doable.

Here's a how to: https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history


But the result will be a very nice and clean git history:


I think this idea stems from Gary Bernhardt ( https://www.destroyallsoftware.com/ )  - someone told me about how he does this all the time and told me.

Wednesday, April 1, 2015

Monday, October 20, 2014

Cool! I just got a pull request!

A couple of weeks ago I wrote a NuGet package because I like Common.Logging and I was under the impression that the NLog adapter for it was getting old. So, I 'rolled my own', checked it in on NuGet and put the source online in GitHub.

A couple of days ago, I got a pull request from someone who's fixed a bug in my code! Did I just start en open source project and did I just get contributers !? ;) Awesome.



The library is nothing, but I'm enjoying the fact that someone's using it and love the constructive way of working together.